Fix search usb repo number when not first #6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
changed the title
rwx788
reviewed
Dec 3, 2018
jknphy
force-pushed
the
fix_enable_usb_repo
branch
from
791dc9e
to
a31d37f
Compare
|
I will merge once travis is done |
|
@jknphy: please, adjust test suite settings and move to the YaST job group for SLE 12 and SLE 15. That would be great if you could trigger the run on osd, so we resolve the ticket before the review. |
|
Well possible that this fixed something - but it did break live image tests: https://openqa.opensuse.org/tests/808630#step/enable_usb_repo/5 |
|
Indeed. It fixed sle15sp1. In this case this test module should be un-scheduled in that test suite as it is enabling the first repo that is already enabled and it is not usb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix search usb repo number when not first and unscheduled unnecessary tests in this scenario.
Requires to setup in the corresponding test suite after merging: